Fixes #131 - Out-ConsoleGridView doesn't handle ANSI escape sequences correctly #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tyler James Leonhardt <tylerl0706@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Fixes #131
Previous to PowerShell 7.1, it would have been uncommon for a cmdlet to receive input decorated with ANSI escape sequences. But support for ANSI was added in 7.1 (see PowerShell/PowerShell#13071).
This PR adds a single line of code, a RegEx, to strip ANSI escape sequences from the input text.
This PR is a draft because
a) A regex is probably not the most robust way to strip ANSI. Apparently PS has a built-in capability (
StringDecorated) but that is internal.b) Pulling in all of Regex is overkill probably
c) I'm not 100% certain that
TypeGetter.csis the right place to do the stripping.Comments appreciated.